[PATCH] D134064: [InstCombine] Baseline tests for folding ((x?1:4)&(y?1:4))==0 to x^y

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 24 12:35:27 PDT 2022


spatel added a comment.

In D134064#3880345 <https://reviews.llvm.org/D134064#3880345>, @marcauberer wrote:

> @spatel is one test case for icmpeq and one for icmpne enough for checking this?

One for each of the non-constant cases should be enough. We're just trying to show that we can (and intended to) handle that kind of pattern via isKnownNonZero or whatever other ValueTracking calls that are used in the transform.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134064/new/

https://reviews.llvm.org/D134064



More information about the llvm-commits mailing list