[PATCH] D125782: [llvm-debuginfo-analyzer] 07 - Compare elements

[Carlos Alberto Enciso via Phabricator via llvm-commits]

CarlosAlbertoEnciso added a comment.

In D125782#3880212 <https://reviews.llvm.org/D125782#3880212>, @kda wrote:

> Some of it can be cleaned up by deleting CompileUnit, but there is other issues: see comment in test source.

The memory leak is caused by those `Child` that are not added to a `Parent`. The other allocated items are removed when the Reader is destroyed.

> The memory ownership model is pretty unusual here.  It seems that this would benefit from more use of unique_ptr to automate ownership (destruction).

One of the areas discussed in the reviews for the tool `llvm-debuginfo-analyzer` is the use `unique_ptr`, which will be addressed once all the patches are commited.

> Without a fix, this will probably need to be rolled back.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125782/new/

https://reviews.llvm.org/D125782