[PATCH] D129868: [SystemZInstPrinter] Introduce markup tags emission

[Antonio Frighetto via Phabricator via llvm-commits]

antoniofrighetto marked 3 inline comments as done.
antoniofrighetto added inline comments.


================
Comment at: llvm/lib/Target/SystemZ/MCTargetDesc/SystemZInstPrinter.cpp:68
   } else
-    O << '%' << RegName;
+    O << markup("<reg:") << '%' << markup(">");
 }
----------------
uweigand wrote:
> You've removed the `RegName` here.
Argh, how could I not even notice? Fixed, thanks for noticing it.


================
Comment at: llvm/lib/Target/SystemZ/MCTargetDesc/SystemZInstPrinter.cpp:79
 template <unsigned N>
-static void printUImmOperand(const MCInst *MI, int OpNum, raw_ostream &O) {
+static void printUImmOperand(const MCInst *MI, int OpNum, raw_ostream &O,
+                             bool UseMarkup) {
----------------
uweigand wrote:
> Could you make those non-static as well, so we don't have to pass in `UseMarkup` explicitly.
Sure!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129868/new/

https://reviews.llvm.org/D129868