[PATCH] D136601: [OpenMP] [OMPIRBuilder] Create a new datatype to hold the unique target region info
Johannes Doerfert via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 24 11:58:41 PDT 2022
jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.
LG, one suggestions, not necessary to address
================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:1826
/// brief Applies action \a Action on all registered entries.
- typedef function_ref<void(unsigned, unsigned, StringRef, unsigned,
+ typedef function_ref<void(TargetRegionEntryInfo EntryInfo,
const OffloadEntryInfoTargetRegion &)>
----------------
`const &` for all of them?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136601/new/
https://reviews.llvm.org/D136601
More information about the llvm-commits
mailing list