[PATCH] D136629: [AMDGPU] Fix delay alu for VOPD with src2acc
Joe Nash via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 24 10:59:28 PDT 2022
Joe_Nash created this revision.
Joe_Nash added reviewers: foad, dp, b-sumner, mbrkusanin, jpages.
Herald added subscribers: kosarev, kerbowa, hiraditya, t-tye, tpr, dstuttard, yaxunl, jvesely, kzhuravl, arsenm.
Herald added a project: All.
Joe_Nash requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.
V_FMAC_F32 and V_DOT2C_F32_F16 have a dummy src2 operand tied to vdst to
inform passes that the instructions read the dst operand. The VOPD
versions of these instructions lacked the dummy operand, which was a
problem for inserting s_delay_alu.
Introduce the dummy src2 operand on the VOPD versions, and fix the VOPD operand
tracking logic to account for it.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D136629
Files:
llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp
llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h
llvm/lib/Target/AMDGPU/VOP2Instructions.td
llvm/lib/Target/AMDGPU/VOPDInstructions.td
llvm/test/CodeGen/AMDGPU/vopd-combine.mir
llvm/test/CodeGen/AMDGPU/vopd-fmac-delay.mir
llvm/test/CodeGen/AMDGPU/vopd-src2acc-delay.mir
llvm/test/MC/AMDGPU/gfx11_asm_vopd_errs.s
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D136629.470223.patch
Type: text/x-patch
Size: 17661 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221024/3a58d28b/attachment-0001.bin>
More information about the llvm-commits
mailing list