[PATCH] D136598: [amdgpu][lds] Use a consistent order of fields in generated structs
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 24 08:20:32 PDT 2022
arsenm added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULowerModuleLDSPass.cpp:399-401
+ llvm::sort(Sorted.begin(), Sorted.end(),
+ [](const GlobalVariable *lhs, const GlobalVariable *rhs) {
+ return lhs->getName() < rhs->getName();
----------------
I thought we had another sort that went on alignment and size with name as a tiebreaker already?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136598/new/
https://reviews.llvm.org/D136598
More information about the llvm-commits
mailing list