[PATCH] D136609: [llvm] Fix minimum Apple Clang requirement

[Kadir Cetinkaya via Phabricator via llvm-commits]

kadircet created this revision.
kadircet added a reviewer: thieta.
Herald added a project: All.
kadircet requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This was stated as 9.3, but as pointed out in
https://discourse.llvm.org/t/rfc-bump-minimal-requirements-apple-clang-9-3-10-0-0-before-4th-tue-in-january/66156/7?u=kadircet
9.3 doesn't exist, hence this was effectively 10.0.

This patch merely reflects the reality more closely.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D136609

Files:
  llvm/cmake/modules/CheckCompilerVersion.cmake
  llvm/docs/GettingStarted.rst
  llvm/docs/ReleaseNotes.rst


Index: llvm/docs/ReleaseNotes.rst
===================================================================
--- llvm/docs/ReleaseNotes.rst
+++ llvm/docs/ReleaseNotes.rst
@@ -61,7 +61,7 @@
 
 * GCC >= 7.1
 * Clang >= 5.0
-* Apple Clang >= 9.3
+* Apple Clang >= 10.0
 * Visual Studio 2019 >= 16.7
 
 Changes to the LLVM IR
Index: llvm/docs/GettingStarted.rst
===================================================================
--- llvm/docs/GettingStarted.rst
+++ llvm/docs/GettingStarted.rst
@@ -239,7 +239,7 @@
 popular host toolchains for specific minimum versions in our build systems:
 
 * Clang 5.0
-* Apple Clang 9.3
+* Apple Clang 10.0
 * GCC 7.1
 * Visual Studio 2019 16.7
 
Index: llvm/cmake/modules/CheckCompilerVersion.cmake
===================================================================
--- llvm/cmake/modules/CheckCompilerVersion.cmake
+++ llvm/cmake/modules/CheckCompilerVersion.cmake
@@ -8,8 +8,8 @@
 set(GCC_SOFT_ERROR 7.1)
 set(CLANG_MIN 5.0)
 set(CLANG_SOFT_ERROR 5.0)
-set(APPLECLANG_MIN 9.3)
-set(APPLECLANG_SOFT_ERROR 9.3)
+set(APPLECLANG_MIN 10.0)
+set(APPLECLANG_SOFT_ERROR 10.0)
 
 # https://en.wikipedia.org/wiki/Microsoft_Visual_C#Internal_version_numbering
 # _MSC_VER == 1927 MSVC++ 14.27 Visual Studio 2019 Version 16.7


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D136609.470168.patch
Type: text/x-patch
Size: 1247 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221024/18f7b7f2/attachment.bin>