[PATCH] D136508: [RISCV] Inline scalar ceil/floor/trunc/rint/round/roundeven.

[Philip Reames via Phabricator via llvm-commits]

reames added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:4103
   case ISD::VP_FROUNDTOZERO:
-    return lowerFTRUNC_FCEIL_FFLOOR_FROUND(Op, DAG, Subtarget);
+    return lowerVectorFTRUNC_FCEIL_FFLOOR_FROUND(Op, DAG, Subtarget);
   }
----------------
Can you precommit a change to add the vector naming so that disappears from this diff? 


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:10816
+  F->insert(I, SinkMBB);
+  // Move all instructions after the sequence to TailMBB.
+  SinkMBB->splice(SinkMBB->end(), MBB,
----------------
Are SinkMBB and TailMBB the same?


================
Comment at: llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp:529
+
+  if (ST->hasVInstructions() && RetTy->isVectorTy()) {
+    auto LT = getTypeLegalizationCost(RetTy);
----------------
Can you precommit the style change here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136508/new/

https://reviews.llvm.org/D136508