[PATCH] D136083: [AArch64][SVE] Use more flag-setting instructions

Peter Waller via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 24 06:46:25 PDT 2022


peterwaller-arm accepted this revision.
peterwaller-arm added a comment.
This revision is now accepted and ready to land.

LGTM, one nit.



================
Comment at: llvm/test/CodeGen/AArch64/sve-ptest-removal-brk.ll:58
 ; CHECK-NEXT:    brkn p2.b, p0/z, p1.b, p2.b
 ; CHECK-NEXT:    ptest p0, p2.b
 ; CHECK-NEXT:    cset w0, ne
----------------
Does this want warrant a comment above it that it's a negtest, or in the name? (otherwise it looks like it's covered by the comment at the top of the file, that these should be removed).



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136083/new/

https://reviews.llvm.org/D136083



More information about the llvm-commits mailing list