[PATCH] D129868: [SystemZInstPrinter] Introduce markup tags emission

[Ulrich Weigand via Phabricator via llvm-commits]

uweigand added inline comments.


================
Comment at: llvm/lib/Target/SystemZ/MCTargetDesc/SystemZInstPrinter.cpp:68
   } else
-    O << '%' << RegName;
+    O << markup("<reg:") << '%' << markup(">");
 }
----------------
You've removed the `RegName` here.


================
Comment at: llvm/lib/Target/SystemZ/MCTargetDesc/SystemZInstPrinter.cpp:79
 template <unsigned N>
-static void printUImmOperand(const MCInst *MI, int OpNum, raw_ostream &O) {
+static void printUImmOperand(const MCInst *MI, int OpNum, raw_ostream &O,
+                             bool UseMarkup) {
----------------
Could you make those non-static as well, so we don't have to pass in `UseMarkup` explicitly.


================
Comment at: llvm/lib/Target/SystemZ/SystemZAsmPrinter.cpp:796
+  } else
+    OS << '%';
+}
----------------
And `RegName` is also missing here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129868/new/

https://reviews.llvm.org/D129868