[PATCH] D135615: [AArch64][ARM] Alter v8.1a neon intrinsics to be target-based, not preprocessor based

Mon Oct 24 03:00:37 PDT 2022

simon_tatham added inline comments.

================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:5854
+  NEONMAP1(vqrdmlshq_s16, arm_neon_vqrdmlsh, Add1ArgType),
+  NEONMAP1(vqrdmlshq_s32, arm_neon_vqrdmlsh, Add1ArgType),
   NEONMAP1(vqrdmulh_v, arm_neon_vqrdmulh, Add1ArgType),
----------------
This patch mostly looks comprehensible to me, but I don't understand what this change has to do with it. Everything else seems to be controlling how intrinsics are enabled/disabled, but the changes in this file seem to be renaming some intrinsics, and there's nothing about that in the commit message.

Is this intentionally part of the same patch?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135615/new/

https://reviews.llvm.org/D135615