[PATCH] D131873: [PowerPC] Optimize compare by using record form in post-RA.

Kai Luo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 23 20:21:55 PDT 2022


lkail added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.cpp:2791
+  unsigned Opc = CmpMI.getOpcode();
+  if (Opc == PPC::CMPLWI ||
+      (Subtarget.isPPC64() && (Opc == PPC::CMPLDI || Opc == PPC::CMPWI)))
----------------
Is
```
if (Opc != PPC::CMPWI && Opc != PPC::CMPDI)
  return false;

// <Explain why CMPWI doesn't apply on PPC64>
if (Subtarget.isPPC64() && Opc == PPC::CMPWI)
  return false;
```
more clear?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131873/new/

https://reviews.llvm.org/D131873



More information about the llvm-commits mailing list