[PATCH] D136461: llvm-reduce: Fix block reduction with unreachable blocks

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 23 16:19:48 PDT 2022


arsenm added inline comments.


================
Comment at: llvm/tools/llvm-reduce/deltas/ReduceBasicBlocks.cpp:199
+      // Delete the dead blocks.
+      DeleteDeadBlocks(DeadBlocks, nullptr, /*KeepOneInputPHIs*/ false);
+      DeadBlocks.clear();
----------------
aeubanks wrote:
> probably not super important, but keeping phis limits the instructions that the basic block pass messes with
Doesn't seem to do anything in the tests


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136461/new/

https://reviews.llvm.org/D136461



More information about the llvm-commits mailing list