[llvm] b1e1719 - llvm-reduce: Add atomic syncscope reduction
Matt Arsenault via llvm-commits
llvm-commits at lists.llvm.org
Sun Oct 23 15:17:08 PDT 2022
Author: Matt Arsenault
Date: 2022-10-23T15:16:55-07:00
New Revision: b1e17199052a757e0173e9570e8ce52eec2b0048
URL: https://github.com/llvm/llvm-project/commit/b1e17199052a757e0173e9570e8ce52eec2b0048
DIFF: https://github.com/llvm/llvm-project/commit/b1e17199052a757e0173e9570e8ce52eec2b0048.diff
LOG: llvm-reduce: Add atomic syncscope reduction
Added:
llvm/test/tools/llvm-reduce/reduce-atomic-syncscope.ll
Modified:
llvm/tools/llvm-reduce/DeltaManager.cpp
llvm/tools/llvm-reduce/deltas/ReduceMemoryOperations.cpp
llvm/tools/llvm-reduce/deltas/ReduceMemoryOperations.h
Removed:
################################################################################
diff --git a/llvm/test/tools/llvm-reduce/reduce-atomic-syncscope.ll b/llvm/test/tools/llvm-reduce/reduce-atomic-syncscope.ll
new file mode 100644
index 000000000000..3a8051a9ef51
--- /dev/null
+++ b/llvm/test/tools/llvm-reduce/reduce-atomic-syncscope.ll
@@ -0,0 +1,82 @@
+; RUN: llvm-reduce --abort-on-invalid-reduction --delta-passes=syncscopes --test FileCheck --test-arg --check-prefixes=INTERESTING,CHECK --test-arg %s --test-arg --input-file %s -o %t
+; RUN: FileCheck -check-prefixes=RESULT,CHECK %s < %t
+
+; CHECK-LABEL: @load_syncscope_keep(
+; INTERESTING: syncscope("agent")
+; RESULT: %op = load atomic i32, ptr %ptr syncscope("agent") seq_cst, align 4
+define i32 @load_syncscope_keep(ptr %ptr) {
+ %op = load atomic i32, ptr %ptr syncscope("agent") seq_cst, align 4
+ ret i32 %op
+}
+
+; CHECK-LABEL: @load_syncscope_drop(
+; INTERESTING: load atomic
+; RESULT: %op = load atomic i32, ptr %ptr seq_cst, align 4
+define i32 @load_syncscope_drop(ptr %ptr) {
+ %op = load atomic i32, ptr %ptr syncscope("agent") seq_cst, align 4
+ ret i32 %op
+}
+
+; CHECK-LABEL: @store_syncscope_keep(
+; INTERESTING: syncscope("agent")
+; RESULT: store atomic i32 0, ptr %ptr syncscope("agent") seq_cst, align 4
+define void @store_syncscope_keep(ptr %ptr) {
+ store atomic i32 0, ptr %ptr syncscope("agent") seq_cst, align 4
+ ret void
+}
+
+; CHECK-LABEL: @store_syncscope_drop(
+; INTERESTING: store
+; RESULT: store atomic i32 0, ptr %ptr seq_cst, align 4
+define void @store_syncscope_drop(ptr %ptr) {
+ store atomic i32 0, ptr %ptr syncscope("agent") seq_cst, align 4
+ ret void
+}
+
+; CHECK-LABEL: @atomicrmw_syncscope_keep(
+; INTERESTING: syncscope("agent")
+; RESULT: %val = atomicrmw add ptr %ptr, i32 3 syncscope("agent") seq_cst, align 4
+define i32 @atomicrmw_syncscope_keep(ptr %ptr) {
+ %val = atomicrmw add ptr %ptr, i32 3 syncscope("agent") seq_cst, align 4
+ ret i32 %val
+}
+
+; CHECK-LABEL: @atomicrmw_syncscope_drop(
+; INTERESTING: atomicrmw
+; RESULT: %val = atomicrmw add ptr %ptr, i32 3 seq_cst, align 4
+define i32 @atomicrmw_syncscope_drop(ptr %ptr) {
+ %val = atomicrmw add ptr %ptr, i32 3 seq_cst
+ ret i32 %val
+}
+
+; CHECK-LABEL: @cmpxchg_syncscope_keep(
+; INTERESTING: syncscope("agent")
+; RESULT: %val = cmpxchg ptr %ptr, i32 %old, i32 %in syncscope("agent") seq_cst seq_cst, align 4
+define { i32, i1 } @cmpxchg_syncscope_keep(ptr %ptr, i32 %old, i32 %in) {
+ %val = cmpxchg ptr %ptr, i32 %old, i32 %in syncscope("agent") seq_cst seq_cst
+ ret { i32, i1 } %val
+}
+
+; CHECK-LABEL: @cmpxchg_syncscope_drop(
+; INTERESTING: = cmpxchg ptr
+; RESULT: %val = cmpxchg ptr %ptr, i32 %old, i32 %in seq_cst seq_cst, align 4
+define { i32, i1 } @cmpxchg_syncscope_drop(ptr %ptr, i32 %old, i32 %in) {
+ %val = cmpxchg ptr %ptr, i32 %old, i32 %in syncscope("agent") seq_cst seq_cst
+ ret { i32, i1 } %val
+}
+
+; CHECK-LABEL: @fence_syncscope_keep(
+; INTERESTING: syncscope("agent")
+; RESULT: fence syncscope("agent") acquire
+define void @fence_syncscope_keep() {
+ fence syncscope("agent") acquire
+ ret void
+}
+
+; CHECK-LABEL: @fence_syncscope_drop(
+; INTERESTING: fence
+; RESULT: fence acquire
+define void @fence_syncscope_drop() {
+ fence syncscope("agent") acquire
+ ret void
+}
diff --git a/llvm/tools/llvm-reduce/DeltaManager.cpp b/llvm/tools/llvm-reduce/DeltaManager.cpp
index 30b4bde247fc..c2656678382e 100644
--- a/llvm/tools/llvm-reduce/DeltaManager.cpp
+++ b/llvm/tools/llvm-reduce/DeltaManager.cpp
@@ -96,6 +96,7 @@ static cl::list<std::string>
DELTA_PASS("module-data", reduceModuleDataDeltaPass) \
DELTA_PASS("opcodes", reduceOpcodesDeltaPass) \
DELTA_PASS("volatile", reduceVolatileInstructionsDeltaPass) \
+ DELTA_PASS("syncscopes", reduceAtomicSyncScopesDeltaPass) \
DELTA_PASS("instruction-flags", reduceInstructionFlagsDeltaPass) \
} while (false)
diff --git a/llvm/tools/llvm-reduce/deltas/ReduceMemoryOperations.cpp b/llvm/tools/llvm-reduce/deltas/ReduceMemoryOperations.cpp
index e20561f7d301..9c68858ee2c8 100644
--- a/llvm/tools/llvm-reduce/deltas/ReduceMemoryOperations.cpp
+++ b/llvm/tools/llvm-reduce/deltas/ReduceMemoryOperations.cpp
@@ -42,3 +42,34 @@ static void removeVolatileInModule(Oracle &O, Module &Mod) {
void llvm::reduceVolatileInstructionsDeltaPass(TestRunner &Test) {
runDeltaPass(Test, removeVolatileInModule, "Reducing Volatile Instructions");
}
+
+static void reduceAtomicSyncScopesInFunction(Oracle &O, Function &F) {
+ for (Instruction &I : instructions(F)) {
+ if (LoadInst *LI = dyn_cast<LoadInst>(&I)) {
+ if (LI->getSyncScopeID() != SyncScope::System && !O.shouldKeep())
+ LI->setSyncScopeID(SyncScope::System);
+ } else if (StoreInst *SI = dyn_cast<StoreInst>(&I)) {
+ if (SI->getSyncScopeID() != SyncScope::System && !O.shouldKeep())
+ SI->setSyncScopeID(SyncScope::System);
+ } else if (AtomicRMWInst *RMW = dyn_cast<AtomicRMWInst>(&I)) {
+ if (RMW->getSyncScopeID() != SyncScope::System && !O.shouldKeep())
+ RMW->setSyncScopeID(SyncScope::System);
+ } else if (AtomicCmpXchgInst *CmpXChg = dyn_cast<AtomicCmpXchgInst>(&I)) {
+ if (CmpXChg->getSyncScopeID() != SyncScope::System && !O.shouldKeep())
+ CmpXChg->setSyncScopeID(SyncScope::System);
+ } else if (FenceInst *Fence = dyn_cast<FenceInst>(&I)) {
+ if (Fence->getSyncScopeID() != SyncScope::System && !O.shouldKeep())
+ Fence->setSyncScopeID(SyncScope::System);
+ }
+ }
+}
+
+static void reduceAtomicSyncScopesInModule(Oracle &O, Module &Mod) {
+ for (Function &F : Mod)
+ reduceAtomicSyncScopesInFunction(O, F);
+}
+
+void llvm::reduceAtomicSyncScopesDeltaPass(TestRunner &Test) {
+ runDeltaPass(Test, reduceAtomicSyncScopesInModule,
+ "Reducing Atomic Sync Scopes");
+}
diff --git a/llvm/tools/llvm-reduce/deltas/ReduceMemoryOperations.h b/llvm/tools/llvm-reduce/deltas/ReduceMemoryOperations.h
index fcb9ed34018d..a985bf03d13f 100644
--- a/llvm/tools/llvm-reduce/deltas/ReduceMemoryOperations.h
+++ b/llvm/tools/llvm-reduce/deltas/ReduceMemoryOperations.h
@@ -13,6 +13,7 @@
namespace llvm {
void reduceVolatileInstructionsDeltaPass(TestRunner &Test);
+void reduceAtomicSyncScopesDeltaPass(TestRunner &Test);
} // namespace llvm
#endif
More information about the llvm-commits
mailing list