[PATCH] D136544: [SLP] For vectorizing chains in basic block, decide order of PHI nodes based on their result use.

Alexey Bataev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 23 09:53:24 PDT 2022


ABataev added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:12442
+      const auto *FirstUserOfPhi2 = cast<Instruction>(*V2->user_begin());
+      if (FirstUserOfPhi1 && FirstUserOfPhi2 &&
+          (FirstUserOfPhi1->getParent() == FirstUserOfPhi2->getParent())) {
----------------
`FirstUserOfPhi1 && FirstUserOfPhi2` is always true, remove it from the condition.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136544/new/

https://reviews.llvm.org/D136544



More information about the llvm-commits mailing list