[PATCH] D136244: [AArch64] Optimize memcmp when the result is tested for [in]equality with 0

Allen zhong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 22 07:22:32 PDT 2022


Allen added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/i128-cmp.ll:11
+; CHECK-NEXT:    ccmp x1, x3, #0, eq
+; CHECK-NEXT:    cset w0, ne
 ; CHECK-NEXT:    ret
----------------
dmgreen wrote:
> Are you sure this is correct? It doesn't look right.
> 
> I think I would expect `ccmp #0, eq;  cset eq`.
Yes, I test the executive for the initial case in https://github.com/llvm/llvm-project/issues/58061


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136244/new/

https://reviews.llvm.org/D136244



More information about the llvm-commits mailing list