[PATCH] D136043: [CodeGen] Replace CCValAssign::Loc with a discriminated union (NFCI)

[Koakuma via Phabricator via llvm-commits]

koakuma added a comment.

Looks okay to me, at least on the SPARC side.
For the CodeGen changes I'm not seeing anything obviously wrong, but it'd be better if someone else also review that part since I'm not very familiar with its workings.



================
Comment at: llvm/lib/Target/Sparc/SparcISelLowering.cpp:1104
     // This floating point argument should be reassigned.
-    CCValAssign NewVA;
 
     // Determine the offset into the argument array.
----------------
Minor nit but it'd be better if this line is removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136043/new/

https://reviews.llvm.org/D136043