[PATCH] D136464: [AArch64][SVE2] Add the SVE2.1 signed and unsigned 2-way dot instructions

Sat Oct 22 06:34:12 PDT 2022

paulwalker-arm accepted this revision.
paulwalker-arm added inline comments.
This revision is now accepted and ready to land.

================
Comment at: llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td:3585-3588
+def SDOT_2WAY_ZZZ_S  : sve2p1_two_way_dot_vv<"sdot", 0b0>;
+def UDOT_2WAY_ZZZ_S  : sve2p1_two_way_dot_vv<"udot", 0b1>;
+def SDOT_2WAY_ZZZI_S : sve2p1_two_way_dot_vvi<"sdot", 0b0>;
+def UDOT_2WAY_ZZZI_S : sve2p1_two_way_dot_vvi<"udot", 0b1>;
----------------
For clarity, can you create a follow up patch to ensure all the SVE dot instructions use this format? This presumably means adding `4WAY`.

================
Comment at: llvm/test/MC/AArch64/SVE2p1/sdot-diagnostics.s:1
+// RUN: not llvm-mc -triple=aarch64 -show-encoding -mattr=+sve2p1 2>&1 < %s | FileCheck %s
+
----------------
Given the positive tests include `movprfx`, is it worth adding negative tests to ensure a suitable error is given when prefixed with a predicated `movprfx`?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136464/new/

https://reviews.llvm.org/D136464