[PATCH] D136340: [tests] precommit tests for D136015

[Allen zhong via Phabricator via llvm-commits]

Allen marked an inline comment as done.
Allen added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/mul_fold.ll:45
+  %retLo = add i8 %shl, %m00
+  call void @use8(i8 %retLo)
+  ret i8 %retLo
----------------
spatel wrote:
> Remove the extra use of the return value in all tests - that does not change anything for the transform.
Done, thanks


================
Comment at: llvm/test/Transforms/InstCombine/mul_fold.ll:72
+  %m10 = mul i8 %In1Hi, %In0Lo
+  call void @use8(i8 %m10)
+  %m01 = mul i8 %In1Lo, %In0Hi
----------------
spatel wrote:
> I think it would be better to not have extra uses of both hi-lo muls in all of the tests. Just keep the extra uses in half of the tests?
> 
> We want to have some coverage for both cases: the mul uses the Lo value, or the mul uses the full in0/in1 directly.
Done, thanks


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136340/new/

https://reviews.llvm.org/D136340