[PATCH] D136394: [Bolt][PseudoProbe] Support new pseudo probe encoding

[Maksim Panchenko via Phabricator via llvm-commits]

maksfb added a comment.

Looks good. There's a couple of styling nits. You might need to run `arc` with `--verbatim` to update Title and Summary fields.



================
Comment at: bolt/lib/Rewrite/RewriteInstance.cpp:611-612
+
+  MCPseudoProbeDecoder::uint64_set GuidFilter;
+  MCPseudoProbeDecoder::uint64_map FuncStartAddrs;
+  for (const auto *F : BC->getAllBinaryFunctions()) {
----------------
nit: following LLVM style for type names (https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly)


================
Comment at: bolt/lib/Rewrite/RewriteInstance.cpp:613-614
+  MCPseudoProbeDecoder::uint64_map FuncStartAddrs;
+  for (const auto *F : BC->getAllBinaryFunctions()) {
+    for (const auto *Sym : F->getSymbols()) {
+      FuncStartAddrs[Function::getGUID(NameResolver::restore(Sym->getName()))] =
----------------
nit: expand auto (https://llvm.org/docs/CodingStandards.html#use-auto-type-deduction-to-make-code-more-readable)


================
Comment at: bolt/lib/Rewrite/RewriteInstance.cpp:3527
+    MCPseudoProbeDecoder::uint64_map FuncStartAddrs;
+    for (const auto *F : BC->getAllBinaryFunctions()) {
+      const uint64_t Addr =
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136394/new/

https://reviews.llvm.org/D136394