[PATCH] D135914: [PseudoProbe] Decode offset based pseudo probe.

Fri Oct 21 15:12:39 PDT 2022

hoy added a comment.

In D135914#3876184 <https://reviews.llvm.org/D135914#3876184>, @maksfb wrote:

> In D135914#3876142 <https://reviews.llvm.org/D135914#3876142>, @hoy wrote:
>
>> Yes, std::map is used everywhere in llvm-profgen. Do you think ADT performs better than it?  I can do a separate refactoring if you don't mind.
>
> I had this diff in mind, but the refactoring sounds good too. ADT avoids malloc, more details at: https://llvm.org/docs/ProgrammersManual.html#map-like-containers-std-map-densemap-etc

I see. Looks like it's great for small keys and values. I'll go through the code base and adjust existing std::map usage (not only for the ones introduced here). Will make a separate change.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135914/new/

https://reviews.llvm.org/D135914