[PATCH] D136496: [bazel] Make labels to third-party dependencies explicit

[Aaron Siddhartha Mondal via Phabricator via llvm-commits]

aaronmondal updated this revision to Diff 469780.
aaronmondal added a comment.

@csigg Ah yes that was an oversight. The `Label()`s are redundant.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136496/new/

https://reviews.llvm.org/D136496

Files:
  utils/bazel/configure.bzl
  utils/bazel/terminfo.bzl
  utils/bazel/zlib.bzl


Index: utils/bazel/zlib.bzl
===================================================================
--- utils/bazel/zlib.bzl
+++ utils/bazel/zlib.bzl
@@ -33,7 +33,7 @@
     implementation = _llvm_zlib_external_impl,
     attrs = {
         "_external_build_template": attr.label(
-            default = Label("//utils/bazel/deps_impl:zlib_external.BUILD"),
+            default = "@llvm-raw//utils/bazel/deps_impl:zlib_external.BUILD",
             allow_single_file = True,
         ),
         "external_zlib": attr.string(
@@ -56,7 +56,7 @@
     implementation = _llvm_zlib_system_impl,
     attrs = {
         "_system_build_template": attr.label(
-            default = Label("//utils/bazel/deps_impl:zlib_system.BUILD"),
+            default = "@llvm-raw//utils/bazel/deps_impl:zlib_system.BUILD",
             allow_single_file = True,
         ),
     },
@@ -73,7 +73,7 @@
     implementation = _llvm_zlib_disable_impl,
     attrs = {
         "_disable_build_template": attr.label(
-            default = Label("//utils/bazel/deps_impl:zlib_disable.BUILD"),
+            default = "@llvm-raw//utils/bazel/deps_impl:zlib_disable.BUILD",
             allow_single_file = True,
         ),
     },
@@ -92,15 +92,15 @@
     implementation = _llvm_zlib_from_env_impl,
     attrs = {
         "_disable_build_template": attr.label(
-            default = Label("//utils/bazel/deps_impl:zlib_disable.BUILD"),
+            default = "@llvm-raw//utils/bazel/deps_impl:zlib_disable.BUILD",
             allow_single_file = True,
         ),
         "_external_build_template": attr.label(
-            default = Label("//utils/bazel/deps_impl:zlib_external.BUILD"),
+            default = "@llvm-raw//utils/bazel/deps_impl:zlib_external.BUILD",
             allow_single_file = True,
         ),
         "_system_build_template": attr.label(
-            default = Label("//utils/bazel/deps_impl:zlib_system.BUILD"),
+            default = "@llvm-raw//utils/bazel/deps_impl:zlib_system.BUILD",
             allow_single_file = True,
         ),
         "external_zlib": attr.label(
Index: utils/bazel/terminfo.bzl
===================================================================
--- utils/bazel/terminfo.bzl
+++ utils/bazel/terminfo.bzl
@@ -27,7 +27,7 @@
 
 _terminfo_disable_attrs = {
     "_disable_build_template": attr.label(
-        default = Label("//utils/bazel/deps_impl:terminfo_disable.BUILD"),
+        default = "@llvm-raw//utils/bazel/deps_impl:terminfo_disable.BUILD",
         allow_single_file = True,
     ),
 }
@@ -148,11 +148,11 @@
 
 _terminfo_system_attrs = _merge_attrs([_terminfo_disable_attrs, {
     "_system_build_template": attr.label(
-        default = Label("//utils/bazel/deps_impl:terminfo_system.BUILD"),
+        default = "@llvm-raw//utils/bazel/deps_impl:terminfo_system.BUILD",
         allow_single_file = True,
     ),
     "_terminfo_test_source": attr.label(
-        default = Label("//utils/bazel/deps_impl:terminfo_test.c"),
+        default = "@llvm-raw//utils/bazel/deps_impl:terminfo_test.c",
         allow_single_file = True,
     ),
     "candidate_system_linkopts": attr.string_list(
Index: utils/bazel/configure.bzl
===================================================================
--- utils/bazel/configure.bzl
+++ utils/bazel/configure.bzl
@@ -33,7 +33,7 @@
 ]
 
 def _overlay_directories(repository_ctx):
-    src_path = repository_ctx.path(Label("//:WORKSPACE")).dirname
+    src_path = repository_ctx.path(Label("@llvm-raw//:WORKSPACE")).dirname
     bazel_path = src_path.get_child("utils").get_child("bazel")
     overlay_path = bazel_path.get_child("llvm-project-overlay")
     script_path = bazel_path.get_child("overlay_directories.py")


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D136496.469780.patch
Type: text/x-patch
Size: 3703 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221021/62d467f7/attachment.bin>