[PATCH] D135780: [IR] Switch everything to use memory attribute

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

In D135780#3875238 <https://reviews.llvm.org/D135780#3875238>, @jdoerfert wrote:

> In D135780#3874753 <https://reviews.llvm.org/D135780#3874753>, @nikic wrote:
>
>> In D135780#3874732 <https://reviews.llvm.org/D135780#3874732>, @jdoerfert wrote:
>>
>>> In D135780#3874715 <https://reviews.llvm.org/D135780#3874715>, @nikic wrote:
>>>
>>>> The only missing part now is Attributor support.
>>>
>>> What is missing there?
>>
>> The interaction of AAMemoryBehavior and AAMemoryLocation with the IR attributes. They need to initialized based on the memory attribute now and also manifest their results that way.
>
> You want me to look into it? I didn't expect this to be much more complicated than the FunctionAttr pass. Maybe I'm wrong.

FunctionAttrs is very simple because it already uses MemoryEffects as the internal representation, so it's mostly just a matter of deleting no longer needed translation code. If you have time to implement Attributor support that would be great, otherwise I'll look into this in more detail next week.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135780/new/

https://reviews.llvm.org/D135780