[PATCH] D134220: [MIPS] Fix useDeprecatedPositionallyEncodedOperands errors.

[James Y Knight via Phabricator via llvm-commits]

jyknight added a comment.

In D134220#3817710 <https://reviews.llvm.org/D134220#3817710>, @BC204 wrote:

> F24716735: bug.log <https://reviews.llvm.org/F24716735>

Thank you for the test code -- but it also fails without my change. A simpler test is just `echo "int f(int a, int b) { return a * b; }" | clang -c -target mips -mips16 -xc - -o /dev/null`

The cause of this failure is that the multiply instructions are -- for some reason -- marked as pseudo-instructions (see e.g. MultRxRyRz16 in Mips16InstrInfo.td). That's certainly completely wrong, and, indeed, bolsters my point that MIPS16 object file emission can't possibly have worked before.

I don't intend this change to actually fix MIPS16 object file emission -- it just makes it marginally less broken in the ways that intersect with the cross-target cleanup I'm trying to do.

So I think this change can be approved as-is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134220/new/

https://reviews.llvm.org/D134220