[PATCH] D136332: [FuncSpec][NFC] Avoid redundant computations of DominatorTree/LoopInfo

Momchil Velikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 21 09:38:18 PDT 2022


chill marked 2 inline comments as done.
chill added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/FunctionSpecialization.cpp:837
   SCCPSolver Solver(DL, GetTLI, M.getContext());
   FunctionSpecializer FS(Solver, GetAC, GetTTI, GetTLI);
   bool Changed = false;
----------------
ChuanqiXu wrote:
> Solver is a member variable of `FunctionSpecializer` already. So the most of the work to rewrite signatures look odd to me
Ah, and oversight on my part, I'll remove the unnecessary parameter.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136332/new/

https://reviews.llvm.org/D136332



More information about the llvm-commits mailing list