[PATCH] D135914: [PseudoProbe] Decode offset based pseudo probe.

[Hongtao Yu via Phabricator via llvm-commits]

hoy added inline comments.


================
Comment at: llvm/include/llvm/MC/MCPseudoProbe.h:343
 
+  /// Whether encoding it based on a starting probe with absolute code address.
+  bool EncodingIsAddrBased = false;
----------------
maksfb wrote:
> 
Good catch, thanks.


================
Comment at: llvm/include/llvm/MC/MCPseudoProbe.h:360-361
+      const uint8_t *Start, std::size_t Size,
+      std::unordered_set<uint64_t> &GuildFilter,
+      const std::unordered_map<uint64_t, uint64_t> &FuncStartAddrs);
+
----------------
maksfb wrote:
> You probably want to use `DenseSet` and `DenseMap` for these and then use type aliases for the interface.
Sounds good, fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135914/new/

https://reviews.llvm.org/D135914