[PATCH] D131830: Clang Support for taskwait nowait clause

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

In D131830#3874169 <https://reviews.llvm.org/D131830#3874169>, @koops wrote:

> Johannes Doerfert,
> Most of your comments are related to avoiding having the kmpc_omp_taskwait_51( ) , in the runtime, and instead introduce a "nowait" related parameter in the kmpc_omp_taskwait( ) itself. I have explained earlier that kmpc_omp_taskwait_51( ) is a  placeholder for introducing new code, at a later stage. The scheduling of tasks might change in the runtime due to "nowait" clause. I have done this with the sole purpose of having backward compatibility. If you feel that is not needed then I will remove the new code and modify the Code Generation also according to your comments.

My comments are not about avoiding `kmpc_omp_taskwait_51` in the runtime. On the contrary. My comments say: Always use `kmpc_omp_taskwait_51` and eliminate the old `kmpc_omp_taskwait`. Do not generate calls to `kmpc_omp_taskwait` but to `kmpc_omp_taskwait_51` instead. Implement `kmpc_omp_taskwait` with a call to `kmpc_omp_taskwait_51`. Doing both will remove most of the new code and we still get the same benefits.
I hope this is clearer now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131830/new/

https://reviews.llvm.org/D131830