[PATCH] D136427: [AArch64][SVE2] Add the SVE2.1 fdot instructions

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/SVEInstrFormats.td:8221
+  let DestructiveInstType = DestructiveOther;
+  let ElementSize = ElementSizeH;
 }
----------------
I guess you taken this by cloning sve_bfloat_dot_base, but is this correct? `ElementSize` is used for `movprfx` handling and usually the largest element type is choose.  Given these are unpredicated instructions I'm wondering if the easiest fix is to just remove the line?

For what it's worth I suspect sve_bfloat_dot_base is also wrong for the same reason.


================
Comment at: llvm/lib/Target/AArch64/SVEInstrFormats.td:8247
+  let DestructiveInstType = DestructiveOther;
+  let ElementSize = ElementSizeH;
 }
----------------
As above?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136427/new/

https://reviews.llvm.org/D136427