[PATCH] D136090: Handle errors in expansion of response files

[Diana Picus via Phabricator via llvm-commits]

rovka added a comment.

Nice tests! :) I have one microscopic nit and one question (because I don't know an awful lot about config files). Thanks for working on this.



================
Comment at: llvm/lib/Support/CommandLine.cpp:1188
+  // macros.
+  if (!RelativeNames && !InConfigFile)
     return Error::success();
----------------
Why do you need to add `!InConfigFile` here and below? 


================
Comment at: llvm/lib/Support/CommandLine.cpp:1204
+    StringRef FileName;
+    if (ArgStr[0] == '@') {
+      FileName = ArgStr.drop_front(1);
----------------
Nit: Why reverse this branch? The code around it `continue`s early, so it's easier to read if this `continue`s early too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136090/new/

https://reviews.llvm.org/D136090