[PATCH] D136425: [Clang][AArch64] Add support for -mcpu=grace

David Spickett via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 21 06:44:06 PDT 2022


DavidSpickett added a comment.

I don't know the background on the wider need for aliases. Makes sense to me in this specific case.

I would also rather this information go into the target parser. Putting it in the .def file is going to be way too much work for this one thing, so just a function in `AArch64TargetParser.h` like `resolveCPUAlias`? It can be just `if grace return v2 else return the original name`, it will be one less piece of target info to track down if/when we modernise the target parsers.

(if we have more aliases in future then yes we could extend the .def records and just implement `resolveCPUAlias` in terms of those)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136425/new/

https://reviews.llvm.org/D136425



More information about the llvm-commits mailing list