[PATCH] D136352: [AArch64] Add SVE2.1 target feature for Armv9-A 2022 Architecture Extension

Fri Oct 21 06:11:07 PDT 2022

david-arm marked an inline comment as done.
david-arm added inline comments.

================
Comment at: llvm/lib/Target/AArch64/AArch64.td:166
+def FeatureSVE2p1: SubtargetFeature<"sve2p1", "HasSVE2p1", "true",
+  "Enable Scalable Vector Extension 2.1  instructions", [FeatureSVE2]>;
+
----------------
paulwalker-arm wrote:
> david-arm wrote:
> > paulwalker-arm wrote:
> > > Extra whitespace
> > The whitespace is deliberate because all the other features have a newline separating them too. I did this for consistency that's all.
> Perhaps you've misunderstood my comment? I just meant there is a double whitespace within `Extension 2.1  instructions`.
Ah yes I see what you mean now. The colour scheme on my browser basically just shows two shades of yellow so it's not very obvious. :)

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136352/new/

https://reviews.llvm.org/D136352