[PATCH] D88663: [AArch64] Use TargetRegisterClass::hasSubClassEq in tryToFindRegisterToRename

Cullen Rhodes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 21 05:55:35 PDT 2022


c-rhodes added a comment.

In D88663#3869433 <https://reviews.llvm.org/D88663#3869433>, @efriedma wrote:

> LGTM
>
> Sorry about the delay, I completely forgot about this.
>
> Renamable implicit defs still feel little weird, but what this patch is doing seems self-consistent, at least.  Maybe we should consider factoring out helper functions for some of register handling stuff.

thanks for accepting. It's been a long time since I've looked at this and I'm not familiar with it anymore but I'll rebase and see if it still works.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88663/new/

https://reviews.llvm.org/D88663



More information about the llvm-commits mailing list