[PATCH] D136425: [Clang][AArch64] Add support for -mcpu=grace
Sjoerd Meijer via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 21 05:54:29 PDT 2022
SjoerdMeijer added a comment.
In D136425#3874298 <https://reviews.llvm.org/D136425#3874298>, @dmgreen wrote:
> I am not against this, but as @ktkachov said it sets a new precedence. We have not in the past added CPU names which are aliases.
>
> If we are doing this, can we build a better way of adding aliases? Maybe a list in TargetParser.def that gets queried at the relevant places?
There are a few unknowns here I think (at least for me):
- Are we going to have (a lot) more aliases? I don't know, but I would guess not.
- Do we later want to distinguish V2 from Grace (for one reason or another)? I don't know yet, but maybe.
I am happy to investigate how we could introduce aliases, but then again, not sure how useful that would be given what I mentioned above; that's the reason I went for this approach, as a one-off, for now.
But let me know what you think, and am happy to look.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136425/new/
https://reviews.llvm.org/D136425
More information about the llvm-commits
mailing list