[PATCH] D136439: [AArch64][SVE2] Add the SVE2.1 bfmlslb and bfmlslt instructions

Cullen Rhodes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 21 05:34:40 PDT 2022


c-rhodes accepted this revision.
c-rhodes added a comment.
This revision is now accepted and ready to land.

Just one nit but otherwise LGTM



================
Comment at: llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td:2123
+  defm BFMLALT_ZZZ : sve_bfloat_matmul_longvecl<0b1, 0b0, "bfmlalt", int_aarch64_sve_bfmlalt>;
+  defm BFMLALB_ZZI : sve_bfloat_matmul_longvecl_idx<0b0, 0b0, "bfmlalb", int_aarch64_sve_bfmlalb_lane>;
+  defm BFMLALT_ZZI : sve_bfloat_matmul_longvecl_idx<0b1, 0b0, "bfmlalt", int_aarch64_sve_bfmlalt_lane>;
----------------
I know it's not introduced by your patch but this should be `ZZZI` as well, same for next instruction.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136439/new/

https://reviews.llvm.org/D136439



More information about the llvm-commits mailing list