[PATCH] D136427: [AArch64][SVE2] Add the SVE2.1 fdot instructions

Cullen Rhodes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 21 05:16:41 PDT 2022


c-rhodes added inline comments.


================
Comment at: llvm/test/MC/AArch64/SME2/fdot_sme2_or_sve2p1-diagnostics.s:1
+// RUN: not llvm-mc -triple=aarch64 -show-encoding -mattr=+sve2p1 2>&1 < %s | FileCheck %s
+
----------------
david-arm wrote:
> I just realised these tests should probably be moved to SVE2. I'll do that in an update!
> I just realised these tests should probably be moved to SVE2. I'll do that in an update!

how about creating an SVE2.1 directory? And I don't think `sme2_or_sve2p1` needs to be in the filename.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136427/new/

https://reviews.llvm.org/D136427



More information about the llvm-commits mailing list