[PATCH] D136381: [ELF] Suppress "duplicate symbol" when resolving STB_WEAK and STB_GNU_UNIQUE in different COMDATs

Fri Oct 21 04:22:48 PDT 2022

peter.smith accepted this revision.
peter.smith added a comment.
This revision is now accepted and ready to land.

Is this symptomatic of a problem in Clang or GCC? It looks like they are not generating the same groups for the same source file which I would expect considering that both claim to implement the itanium ABI. I couldn't understand at first why the STB_GNU_UNIQUE symbols were not getting discarded as part of a non-prevailing group, however the clang and gcc (I used aarch64-none-linux-gnu-g++ (fsf-10.39) 10.1.1 20200629) generated groups have different signatures so we end up with two groups with one STB_GNU_UNIQUE and one STB_WEAK.

I've approved as the groups are different even when `-fno-gnu-unique` is used for GCC so it makes sense to treat STB_GNU_WEAK and STB_GNU_UNIQUE the same way. However this does feel less than ideal. We end up with sections from both groups in the ELF file but only one set of symbols. Probably the job of the compiler to fix, not sure there is much we can do at link time.

================
Comment at: lld/test/ELF/comdat-binding2.s:32
+## GCC with the default --enable-gnu-unique-object configuration
+	.weak	_ZN1BIiE1aE
+	.section	.bss._ZN1BIiE1aE,"awG", at nobits,_ZN1BIiE1aE,comdat
----------------
Can we add to the comment as I found it difficult to spot.
## Note the different group signature for the second group.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136381/new/

https://reviews.llvm.org/D136381