[PATCH] D136430: [AAArch64][Windows] Fix the crash when running ninja check-asan

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 21 02:46:51 PDT 2022


mstorsjo added a comment.

In D136430#3873869 <https://reviews.llvm.org/D136430#3873869>, @bcl5980 wrote:

> In D136430#3873863 <https://reviews.llvm.org/D136430#3873863>, @mstorsjo wrote:
>
>> If the issue was on the level that the number of SEH opcodes didn't match the number of instructions, then D131394 <https://reviews.llvm.org/D131394> should have triggered when compiling the object file too - can you clarify whether this was the case (but you might have tested with an older version before D131394 <https://reviews.llvm.org/D131394> had been landed), or if it was a case where the number of opcodes/instructions matched while being incorrect?
>>
>> The fix in itself probably is correct in any case.
>
> I use today's main branch to test so D131394 <https://reviews.llvm.org/D131394> is already landed. The test error is:
>
>   Incorrect size for ?catch$3@?0??_Osfx@?$basic_ostream at DU?$char_traits at D@std@@@std@@QEAAXXZ at 4HA epilogue: 8 bytes of instructions in range, but .seh directives corresponding to 12 bytes

Ok, great! So then that check works exactly as intended for catching issues like these!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136430/new/

https://reviews.llvm.org/D136430



More information about the llvm-commits mailing list