[PATCH] D136432: [AMDGPU] Combine BFI instructions.

[Jannik Silvanus via Phabricator via llvm-commits]

jsilvanus added a comment.

One inline comment on a comment :).

Slightly related: How do we handle `(X1 & Y) | (X2 & ~Y)` where `Y` is a variable?



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp:2164
+// b) the constants are disjoint
+// This function gathers all operands, does the neccessary checks and then creates the V_BFI instructions.
+bool AMDGPUDAGToDAGISel::Select_BFI(SDNode *N) {
----------------
It seems you support arbitrarily nested expressions, maybe mention here that the example with three clauses is just an example?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136432/new/

https://reviews.llvm.org/D136432