[PATCH] D136430: [AAArch64][Windows] Fix the crash when running ninja check-asan

David Spickett via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 21 01:52:48 PDT 2022


DavidSpickett added a reviewer: omjavaid.
DavidSpickett added a comment.

@omjavaid has also been looking at sanitizers on Windows on Arm.

> Do I need to precommit the test to make the test cleaner?

As in, commit a test that shows the exiting broken behaviour, then this patch just has the correction? Sounds like a good idea to me. You can land them right next to each other in any case.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136430/new/

https://reviews.llvm.org/D136430



More information about the llvm-commits mailing list