[PATCH] D135575: [AArch64]SME2 Multi-vector-Multiple Vectors SQDMULH instructions

Caroline via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 21 01:39:15 PDT 2022


CarolineConcatto added a comment.

Do you have any sqdmulh-diagnostics.s with negative tests for these instructions?
Yes, in sqdmulh-diagnostics.s. I added more tests



================
Comment at: llvm/lib/Target/AArch64/AArch64SMEInstrInfo.td:278
+defm SQDMULH_4Z4Z : sme2_sqdmulh_vector_vg4_multi<"sqdmulh">;
+
 }
----------------
sdesmalen wrote:
> Out of interest, why are the multiple and single vector variants of sqdmulh not part of this patch?
No special reason. I just did not wanted this patch
https://reviews.llvm.org/D135563
to become too big.
It is not simple, for myself, to get a balance correct.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135575/new/

https://reviews.llvm.org/D135575



More information about the llvm-commits mailing list