[PATCH] D135941: [X86] Support AMX-FP16

[Phoebe Wang via Phabricator via llvm-commits]

pengfei added inline comments.


================
Comment at: clang/include/clang/Driver/Options.td:4526
 def mno_amx_bf16 : Flag<["-"], "mno-amx-bf16">, Group<m_x86_Features_Group>;
 def mtamx_int8 : Flag<["-"], "mamx-int8">, Group<m_x86_Features_Group>;
 def mno_amx_int8 : Flag<["-"], "mno-amx-int8">, Group<m_x86_Features_Group>;
----------------
This seems a typo?


================
Comment at: clang/include/clang/Driver/Options.td:4530-4531
 def mno_amx_tile : Flag<["-"], "mno-amx-tile">, Group<m_x86_Features_Group>;
+def mamx_fp16 : Flag<["-"], "mamx-fp16">, Group<m_x86_Features_Group>;
+def mno_amx_fp16 : Flag<["-"], "mno-amx-fp16">, Group<m_x86_Features_Group>;
 def msse : Flag<["-"], "msse">, Group<m_x86_Features_Group>;
----------------
Better to move them below amx_bf16 for ordering.


================
Comment at: clang/lib/Basic/Targets/X86.cpp:886
       .Case("amx-tile", true)
+      .Case("amx-fp16", true)
       .Case("avx", true)
----------------
ditto.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135941/new/

https://reviews.llvm.org/D135941