[PATCH] D135933: [X86] Add CMPCCXADD instructions.

[Freddy, Ye via Phabricator via llvm-commits]

FreddyYe marked 4 inline comments as done.
FreddyYe added inline comments.


================
Comment at: llvm/lib/Target/X86/X86InstrCompiler.td:1026
 
+let Predicates = [HasCMPCCXADD, In64BitMode], Defs = [EFLAGS],
+    Constraints = "$dstsrc2 = $dst" in {
----------------
craig.topper wrote:
>  X86InstrCompiler.td is for pseudos and isCodeGenOnly=1 instructions. Basically things only needed by CodeGen and not the assembler/disassembler.
I was to make it near "cmpxchg". What about llvm/lib/Target/X86/X86InstrInfo.td?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135933/new/

https://reviews.llvm.org/D135933