[PATCH] D135941: [X86] Support AMX-FP16

[Xiang Zhang via Phabricator via llvm-commits]

xiangzhangllvm added inline comments.


================
Comment at: llvm/test/MC/X86/AMX/x86-64-amx-fp16-att.s:5
+// CHECK: encoding: [0xc4,0xe2,0x53,0x5c,0xdc]
+               tdpfp16ps       %tmm5, %tmm4, %tmm3
----------------
RKSimon wrote:
> merge att/intel testing into the same file and use --check-prefix to test them
Yes, that is our previous action, I think the most benefit is that we can easy to cmp them for same encoding (put them together) not reduce file number.
but now we are try to use tools auto generate/verify them. So split them is more easy/clear for tools generating/verify.  (I think it is complex to let tools “by turns” generate same encoding for different style instructions.)
So should we change the old way to let tools easy to auto-gen tests? (And I found we have split them in llvm/test/MC/X86/AMX/ before.)
Thanks again for careful reviewing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135941/new/

https://reviews.llvm.org/D135941