[PATCH] D136374: [lld-macho] Don't put entries with less than 2 usages into the common table.

Vy Nguyen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 20 13:14:17 PDT 2022


oontvoo added inline comments.


================
Comment at: lld/test/MachO/fold-common-encoding.s:2
+# REQUIRES: x86
+# RUN: rm -rf %t; split-file %s %t
+
----------------
This is only 1 test at the moment, but I have another patch coming which needs two input files - so using `split-file` in this patch to make the diff easier


================
Comment at: lld/test/MachO/fold-common-encoding.s:17
+CHECK:  Number of indices in array:                0x2
+CHECK:  Common encodings: (count = 1)
+CHECK:    encoding[0]: 0x[[#%x, COMMON_ENC:]]
----------------
This used to include the `_exception1` entry, too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136374/new/

https://reviews.llvm.org/D136374



More information about the llvm-commits mailing list