[PATCH] D133416: [lit] Test changes to make it work with bazel

[Stella Stamenova via Phabricator via llvm-commits]

stella.stamenova added a comment.
Herald added a subscriber: zero9178.

This change has caused intermittent failures in reorder.py on Windows. I wonder why the changes to the test were necessary and if we can update it so it works consistently on Windows as well as with bazel:

  2022-10-20T18:53:12.1217293Z -- Testing: 67311 tests, 32 workers --
  2022-10-20T18:57:48.7694530Z Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90
  2022-10-20T18:57:48.7695526Z FAIL: lit :: reorder.py (64557 of 67311)
  2022-10-20T18:57:48.7697302Z ******************** TEST 'lit :: reorder.py' FAILED ********************
  2022-10-20T18:57:48.7697817Z Script:
  2022-10-20T18:57:48.7698264Z --
  2022-10-20T18:57:48.7698690Z : 'RUN: at line 3';   cp Inputs/reorder/lit_test_times Inputs/reorder/.lit_test_times.txt
  2022-10-20T18:57:48.7699728Z : 'RUN: at line 4';   not env -u FILECHECK_OPTS "C:\hostedtoolcache\windows\Python\3.9.13\x64\python3.exe" D:\a\_work\1\s\llvm-project\llvm\utils\lit\lit.py -j1 Inputs/reorder > D:\a\_work\1\b\llvm\Release\utils\lit\tests\Output\reorder.py.tmp.out
  2022-10-20T18:57:48.7700832Z : 'RUN: at line 5';   FileCheck --check-prefix=TIMES < Inputs/reorder/.lit_test_times.txt D:\a\_work\1\b\llvm\Release\utils\lit\tests\reorder.py
  2022-10-20T18:57:48.7701719Z : 'RUN: at line 6';   FileCheck < D:\a\_work\1\b\llvm\Release\utils\lit\tests\Output\reorder.py.tmp.out D:\a\_work\1\b\llvm\Release\utils\lit\tests\reorder.py
  2022-10-20T18:57:48.7702285Z --
  2022-10-20T18:57:48.7702796Z Exit Code: 1
  2022-10-20T18:57:48.7702962Z 
  2022-10-20T18:57:48.7703273Z Command Output (stdout):
  2022-10-20T18:57:48.7703761Z --
  2022-10-20T18:57:48.7704025Z $ ":" "RUN: at line 3"
  2022-10-20T18:57:48.7704480Z $ "cp" "Inputs/reorder/lit_test_times" "Inputs/reorder/.lit_test_times.txt"
  2022-10-20T18:57:48.7704930Z $ ":" "RUN: at line 4"
  2022-10-20T18:57:48.7705561Z $ "not" "env" "-u" "FILECHECK_OPTS" "C:\hostedtoolcache\windows\Python\3.9.13\x64\python3.exe" "D:\a\_work\1\s\llvm-project\llvm\utils\lit\lit.py" "-j1" "Inputs/reorder"
  2022-10-20T18:57:48.7706327Z $ ":" "RUN: at line 5"
  2022-10-20T18:57:48.7706759Z $ "FileCheck" "--check-prefix=TIMES" "D:\a\_work\1\b\llvm\Release\utils\lit\tests\reorder.py"
  2022-10-20T18:57:48.7707138Z # command stderr:
  2022-10-20T18:57:48.7707706Z D:\a\_work\1\b\llvm\Release\utils\lit\tests\reorder.py:14:15: error: TIMES-NEXT: expected string not found in input
  2022-10-20T18:57:48.7708049Z # TIMES-NEXT: new-test.txt
  2022-10-20T18:57:48.7708214Z               ^
  2022-10-20T18:57:48.7708414Z <stdin>:5:21: note: scanning from here
  2022-10-20T18:57:48.7708620Z 1.562667e-02 aaa.txt
  2022-10-20T18:57:48.7708791Z                     ^
  2022-10-20T18:57:48.7708877Z 
  2022-10-20T18:57:48.7709026Z Input file: <stdin>
  2022-10-20T18:57:48.7709254Z Check file: D:\a\_work\1\b\llvm\Release\utils\lit\tests\reorder.py
  2022-10-20T18:57:48.7709402Z 
  2022-10-20T18:57:48.7709620Z -dump-input=help explains the following input dump.
  2022-10-20T18:57:48.7709744Z 
  2022-10-20T18:57:48.7709894Z Input was:
  2022-10-20T18:57:48.7710035Z <<<<<<
  2022-10-20T18:57:48.7710208Z          1: 4.200000e+01 not-executed.txt 
  2022-10-20T18:57:48.7710439Z          2: 1.563215e-02 subdir/ccc.txt 
  2022-10-20T18:57:48.7710660Z          3: 1.561761e-02 bbb.txt 
  2022-10-20T18:57:48.7711008Z          4: -1.561570e-02 fff.txt 
  2022-10-20T18:57:48.7711315Z          5: 1.562667e-02 aaa.txt 
  2022-10-20T18:57:48.7711527Z next:14                         X error: no match found
  2022-10-20T18:57:48.7711719Z >>>>>>
  2022-10-20T18:57:48.7711780Z 
  2022-10-20T18:57:48.7711955Z error: command failed with exit status: 1
  2022-10-20T18:57:48.7712068Z 
  2022-10-20T18:57:48.7712209Z --
  2022-10-20T18:57:48.7712271Z 
  2022-10-20T18:57:48.7712418Z ********************
  2022-10-20T18:58:11.6923022Z Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 
  2022-10-20T18:58:12.6993950Z ********************
  2022-10-20T18:58:12.6995485Z Failed Tests (1):
  2022-10-20T18:58:12.6995765Z   lit :: reorder.py


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133416/new/

https://reviews.llvm.org/D133416