[PATCH] D135590: [ThinLTO][ELF] Add a ThinLTO warning if cache_size_bytes or cache_size_files is too small for the current link job.

[Ying Yi via Phabricator via llvm-commits]

MaggieYi added inline comments.


================
Comment at: lld/ELF/LTO.cpp:210
+  if (Policy.MaxSizeBytes > 0) {
+    size_t Size = 0;
+    for (const auto &File : files)
----------------
MaskRay wrote:
> lld uses `camelCase` variable names.
Thanks, fixed.


================
Comment at: lld/ELF/LTO.cpp:218
+           "files consumed by the current link job exceeds maximum cache "
+           "size; consider adjusting --thinlto-cache-policy.");
+  }
----------------
MaskRay wrote:
> Drop trailing period:)
> 
> I haven't read through the patch yet.
Thanks, fixed :) .


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135590/new/

https://reviews.llvm.org/D135590