[PATCH] D136197: [ASAN] Don't inline when -asan-max-inline-poisoning-size=0

Roy Sundahl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 20 08:49:03 PDT 2022


rsundahl added inline comments.


================
Comment at: compiler-rt/test/asan/TestCases/set_shadow_test.c:16-22
+void __asan_set_shadow_01(size_t addr, size_t size);
+void __asan_set_shadow_02(size_t addr, size_t size);
+void __asan_set_shadow_03(size_t addr, size_t size);
+void __asan_set_shadow_04(size_t addr, size_t size);
+void __asan_set_shadow_05(size_t addr, size_t size);
+void __asan_set_shadow_06(size_t addr, size_t size);
+void __asan_set_shadow_07(size_t addr, size_t size);
----------------
vitalybuka wrote:
> if we want to optimize, these can't have anything other than 1 as size
Good value @vitalybuka. Thank you. I put asserts on the implementation side (compiler-rt/lib/asan/asan_poisoning.cpp) where I expect never to get anything but single byte partial poisoning calls but I will firm that up where the optimizer can see it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136197/new/

https://reviews.llvm.org/D136197



More information about the llvm-commits mailing list