[PATCH] D136358: [AArch64][SVE2] Add the SVE2.1 fclamp instructions

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64SMEInstrInfo.td:251
+let Predicates = [HasSVE2p1orSME2] in {
+defm FCLAMP_ZZZ : sve2_fclamp<"fclamp">;
+} // End let Predicates = [HasSVE2p1orSME2]
----------------
david-arm wrote:
> sdesmalen wrote:
> > nit: sve2p1_ ? I also wonder if these should live in AArch64SVEInstrInfo.td instead?
> That's a good question! I followed the same precedent as the SVE2 instructions above that were added for SME. Perhaps we can also move those to AArch64SVEInstrInfo.td for consistency?
Yes, I think so. If you move them to AArch64SVEInstrInfo.td, they should probably have a different predicate too, i.e. `HasSVE2p1orSME` (instead of `HasSVE2p1orSME2` as you introduced here).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136358/new/

https://reviews.llvm.org/D136358