[PATCH] D136358: [AArch64][SVE2] Add the SVE2.1 fclamp instructions

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 20 07:34:38 PDT 2022


sdesmalen added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64SMEInstrInfo.td:247
+//===----------------------------------------------------------------------===//
+// SVE2.1 instructions
+//===----------------------------------------------------------------------===//
----------------
nit: SME2 or SVE2.1 instructions


================
Comment at: llvm/lib/Target/AArch64/AArch64SMEInstrInfo.td:251
+let Predicates = [HasSVE2p1orSME2] in {
+defm FCLAMP_ZZZ : sve2_fclamp<"fclamp">;
+} // End let Predicates = [HasSVE2p1orSME2]
----------------
nit: sve2p1_ ? I also wonder if these should live in AArch64SVEInstrInfo.td instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136358/new/

https://reviews.llvm.org/D136358



More information about the llvm-commits mailing list