[PATCH] D135799: libcxxabi [PR58117][NFC]: Open code lower bound

Louis Dionne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 20 06:13:26 PDT 2022


ldionne added a comment.

> I thought you disliked that solution -- have you changed your mind? (the define would work for me too)

Did I mention that in another review? I don't remember. Either way, this LGTM too, but I think the code may break in the future in a similar way if someone unsuspecting adds a use of a stdlib algorithm, or even worse, if we add new assertions to existing stdlib algorithms.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135799/new/

https://reviews.llvm.org/D135799



More information about the llvm-commits mailing list